fix(mobile): blank notifications page after enabling notifications

the old notification toggles were removed in a cleanup, so once notifications were enabled the page had nothing left and went blank. show a "notifications enabled" status tile with a shortcut to the system notification settings instead.

i18n/en.json

@@ -1715,6 +1715,9 @@
   "notes": "Notes",
   "nothing_here_yet": "Nothing here yet",
   "notification_backup_reliability": "Enable notifications to improve background backup reliability",
+  "notification_enabled_list_tile_content": "Immich uses notifications for background backup. Manage them in your device settings.",
+  "notification_enabled_list_tile_open_button": "Open settings",
+  "notification_enabled_list_tile_title": "Notifications enabled",
   "notification_permission_dialog_content": "To enable notifications, go to Settings and select allow.",
   "notification_permission_list_tile_content": "Grant permission to enable notifications.",
   "notification_permission_list_tile_enable_button": "Enable Notifications",

mobile/lib/widgets/settings/notification_setting.dart

@@ -48,6 +48,14 @@ class NotificationSetting extends HookConsumerWidget {
                   showPermissionsDialog();
                 }
               }),
+        )
+      else
+        SettingsButtonListTile(
+          icon: Icons.notifications_active_outlined,
+          title: 'notification_enabled_list_tile_title'.tr(),
+          subtileText: 'notification_enabled_list_tile_content'.tr(),
+          buttonText: 'notification_enabled_list_tile_open_button'.tr(),
+          onButtonTap: () => openAppSettings(),
         ),
     ];
 

packages/plugin-core/manifest.json

@@ -289,34 +289,6 @@
         "required": ["albumIds"]
       }
     },
-    {
-      "name": "assetDataWebhook",
-      "title": "Trigger Webhook",
-      "description": "POST asset data to any URL",
-      "types": ["AssetV1"],
-      "hostFunctions": true,
-      "schema": {
-        "type": "object",
-        "properties": {
-          "url": {
-            "type": "string",
-            "title": "URL",
-            "description": "Asset data will be POSTed to this URL as a JSON object"
-          },
-          "headerName": {
-            "type": "string",
-            "title": "Header name",
-            "description": "The name of an additional header to include with the request (e.g. authentication)"
-          },
-          "headerValue": {
-            "type": "string",
-            "title": "Header value",
-            "description": "The value of the additional header"
-          }
-        },
-        "required": ["url"]
-      }
-    },
     {
       "name": "noop1",
       "title": "DEV: Nested properties",

packages/plugin-core/src/index.d.ts

@@ -5,7 +5,6 @@ declare module 'extism:host' {
     createAlbum(ptr: PTR): I64;
     addAssetsToAlbum(ptr: PTR): I64;
     addAssetsToAlbums(ptr: PTR): I64;
-    httpRequest(ptr: PTR): I64;
   }
 }
 
@@ -25,5 +24,4 @@ declare module 'main' {
   export function assetTimeline(): I32;
   export function assetTrash(): I32;
   export function assetAddToAlbums(): I32;
-  export function assetDataWebhook(): I32;
 }

packages/plugin-core/src/index.ts

@@ -181,25 +181,3 @@ export const assetAddToAlbums = () => {
     return {};
   });
 };
-
-export const assetDataWebhook = () => {
-  return wrapper<WorkflowType.AssetV1, { url: string; headerName?: string; headerValue?: string }>(
-    ({ config, data, functions }) => {
-      let headers: Record<string, string> = {
-        'Content-Type': 'application/json',
-      };
-
-      if (config.headerName && config.headerValue) {
-        headers[config.headerName] = config.headerValue;
-      }
-
-      functions.httpRequest(config.url, {
-        method: 'POST',
-        body: JSON.stringify(data.asset),
-        headers,
-      });
-
-      return {};
-    },
-  );
-};

packages/plugin-sdk/src/host-functions.ts

@@ -13,7 +13,6 @@ declare module 'extism:host' {
     createAlbum(ptr: PTR): I64;
     addAssetsToAlbum(ptr: PTR): I64;
     addAssetsToAlbums(ptr: PTR): I64;
-    httpRequest(ptr: PTR): I64;
   }
 }
 
@@ -34,11 +33,6 @@ type HostFunctionResult<T> =
 
 type QueryParams<T extends (...args: any) => any> = Parameters<T>[0];
 type AlbumSearchDto = QueryParams<typeof getAllAlbums>;
-type HttpRequestOptions = {
-  method?: string;
-  headers?: Record<string, string>;
-  body?: string;
-};
 
 export const hostFunctions = (authToken: string) => {
   const host = Host.getFunctions();
@@ -81,11 +75,5 @@ export const hostFunctions = (authToken: string) => {
       ),
     addAssetsToAlbums: ({ assetIds, albumIds }: AlbumsToAssets) =>
       call('addAssetsToAlbums', authToken, [{ albumIds, assetIds }]),
-    httpRequest: (url: string, options?: HttpRequestOptions) =>
-      call<[string, HttpRequestOptions | undefined], string>(
-        'httpRequest',
-        authToken,
-        [url, options],
-      ),
   };
 };

server/src/services/workflow-execution.service.ts

@@ -74,26 +74,12 @@ export class WorkflowExecutionService extends BaseService {
     const addAssetsToAlbums = this.wrap<[dto: AlbumsAddAssetsDto]>((authDto, args) =>
       albumService.addAssetsToAlbums(authDto, ...args),
     );
-    const httpRequest = this.wrap<
-      [
-        url: string,
-        options?: {
-          method?: string;
-          headers?: Record<string, string>;
-          body?: string;
-        },
-      ]
-    >(async (_, args) => {
-      const res = await fetch(...args);
-      return res.text();
-    });
 
     const functions = {
       searchAlbums,
       createAlbum,
       addAssetsToAlbum,
       addAssetsToAlbums,
-      httpRequest,
     };
 
     const stubs: typeof functions = {
@@ -101,7 +87,6 @@ export class WorkflowExecutionService extends BaseService {
       createAlbum: dummy,
       addAssetsToAlbum: dummy,
       addAssetsToAlbums: dummy,
-      httpRequest: dummy,
     };
 
     const plugins = await this.pluginRepository.getForLoad();