Merge pull request #10472

18b634a wallet2: reject duplicate outputs in reserve proofs (selsta)
This commit is contained in:
tobtoht
2026-04-29 13:32:50 +00:00
+9
View File
@@ -12651,6 +12651,15 @@ bool wallet2::check_reserve_proof(const cryptonote::account_public_address &addr
catch(...) {}
THROW_WALLET_EXCEPTION_IF(!loaded, error::wallet_internal_error, "Failed to parse reserve proof signature data");
std::unordered_set<crypto::key_image> seen_key_images;
std::set<std::pair<crypto::hash, uint64_t>> seen_outputs;
for (const reserve_proof_entry &proof : proofs)
{
THROW_WALLET_EXCEPTION_IF(!seen_key_images.insert(proof.key_image).second, error::wallet_internal_error, "Duplicate key image in reserve proof");
THROW_WALLET_EXCEPTION_IF(!seen_outputs.emplace(proof.txid, proof.index_in_tx).second, error::wallet_internal_error, "Duplicate output in reserve proof");
}
THROW_WALLET_EXCEPTION_IF(subaddr_spendkeys.count(address.m_spend_public_key) == 0, error::wallet_internal_error,
"The given address isn't found in the proof");