Commit Graph
11453 Commits
Author SHA1 Message Date
WeebDataHoarder 39c7a22856 Send ZMQ miner notifications after txpool additions
Bug was introduced in c069c04ede, before this txpool additions were not notified on block addition

When receiving blocks with previously unknown conditions, miner data was sent first, but txpool add events for already-added transactions in previous block were sent afterward. Miners would then include already-mined transactions in their new templates due to receiving the mistimed txpool add event.

The fix is to send miner notifications AFTER txpool events are sent, and before normal block notifications are sent (for mining switch speed purposes)

Fixes c069c04ede / #9135
Fixes dfee15eee1 / #7891
2025-09-24 09:22:28 +02:00
tobtoht 0eaac4445e Merge pull request #10070
53375a7 CMake: fix msys/ICU compilation failure (0xFFFC0000)
2025-09-08 18:17:15 +00:00
0xFFFC0000 53375a79ce CMake: fix msys/ICU compilation failure 2025-09-08 17:38:04 +01:00
tobtoht 81f948a4a1 Merge pull request #10063
7e3edc2 epee: only parse valid port (selsta)
2025-08-31 09:41:18 +00:00
selsta 7e3edc29c6 epee: only parse valid port
Reported by hacksandhops and Ada Logic.
2025-08-31 00:13:55 +02:00
tobtoht 911c6799dd Merge pull request #10062
0dc791d ci: macos: reinstall cmake (tobtoht)
2025-08-30 17:45:30 +00:00
tobtoht 0dc791dec7 ci: macos: reinstall cmake 2025-08-30 19:26:56 +02:00
tobtoht d87edf57fc Merge pull request #10051
f921431 checkpoints: update to a recent block height (selsta)
v0.18.4.2
2025-08-21 16:29:21 +00:00
tobtoht 22fc8f9a09 Merge pull request #10048
e6f43df epee: include math header for upcoming Boost 1.89 (Michael Cho)
2025-08-21 16:28:02 +00:00
tobtoht cc3b1cb29a Merge pull request #10047
e23b759 Skip ping connections in outgoing count (Lee *!* Clagett)
2025-08-21 16:27:33 +00:00
tobtoht eb39d64e40 Merge pull request #10031
f54edc4 add depends command for Apple Silicon macOS binaries (woodser)
2025-08-21 16:23:24 +00:00
selsta f921431f34 checkpoints: update to a recent block height 2025-08-20 18:42:13 +02:00
Michael Choandselsta e6f43df56a epee: include math header for upcoming Boost 1.89 2025-08-20 18:06:18 +02:00
Lee *!* Clagett e23b759b37 Skip ping connections in outgoing count 2025-08-19 17:16:05 -04:00
woodser f54edc4da1 add depends command for Apple Silicon macOS binaries 2025-08-10 09:17:14 -04:00
tobtoht 2987b72006 Merge pull request #10019
32f701b build: prepare v0.18.4.2 (selsta)
2025-08-05 16:09:20 +00:00
selsta 32f701b0cd build: prepare v0.18.4.2 2025-08-01 17:25:46 +02:00
tobtoht 35efc7e340 Merge pull request #10015
8f98dac wallet: deprecate wallet2::find_and_save_rings() (jeffro256)
2025-08-01 11:52:22 +00:00
jeffro256andj-berman 8f98dac4f0 wallet: deprecate wallet2::find_and_save_rings()
Rings for outgoing transactions are stored within the scanning code since the last hardfork,
so this code is largely unneccessary now.

Co-authored-by: j-berman <justinberman@protonmail.com>
2025-07-29 12:32:20 -05:00
tobtoht ec870e5070 Merge pull request #9998
2e0030c set do_not_relay always false in submit_multisig_main (SNeedlewoods)
v0.18.4.1
2025-07-14 16:59:19 +00:00
SNeedlewoods 2e0030cba8 set do_not_relay always false in submit_multisig_main 2025-07-14 18:41:25 +02:00
tobtoht 04f47716c0 Merge pull request #9994
0e076d6 ci: gitian: update runner to 22.04 (tobtoht)
2025-07-14 15:03:52 +00:00
tobtoht 0e076d63fe ci: gitian: update runner to 22.04 2025-07-14 15:25:29 +02:00
tobtoht 4610926dfc Merge pull request #9991
7acee8d ci: bump debian to 11 [0.18] (tobtoht)
2025-07-13 20:17:23 +00:00
tobtoht d95cd26330 Merge pull request #9982
45152f9 rpc: return error correctly on bad key image string (jeffro256)
2025-07-13 16:52:45 +00:00
tobtoht 191a41ed3a Merge pull request #9983
bec90df add do_not_relay option to submit_multisig_main command in simplewallet (SNeedlewoods)
2025-07-13 16:51:20 +00:00
tobtoht f8c575e0b1 Merge pull request #9986
1d3d30c crypto: check+throw for Cryptonight v1 invalid input (jeffro256)
2025-07-13 16:50:31 +00:00
jeffro256 1d3d30c507 crypto: check+throw for Cryptonight v1 invalid input
If `crypto::cn_slow_hash()` is called with `variant=1` and an input length of less thab 43 bytes, it triggers a program exit.
This checks first and throws an exception instead.

Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!
2025-07-11 11:37:08 -05:00
jeffro256 45152f9ef0 rpc: return error correctly on bad key image string
Because of the missing `return` statement, the status is set to "OK" later on in the method when it shouldn't be.

Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!
2025-07-11 11:27:12 -05:00
SNeedlewoods bec90df7ec add do_not_relay option to submit_multisig_main command in simplewallet 2025-07-11 17:48:33 +02:00
tobtoht 3e218c2021 Merge pull request #9958
9002681 Add new dynamic fees to ZMQ (Lee Clagett)
2025-07-10 17:32:31 +00:00
tobtoht 0b739fdf58 Merge pull request #9946
b96af8e build: prepare v0.18.4.1 (selsta)
2025-07-10 12:28:33 +00:00
tobtoht 8b4f0a6258 Merge pull request #9954
1da19da wallet: refactor subaddress expansion & add to transfer test (jeffro256)
e23d51b wallet: improve lookahead logic & make rpc persistent (Justin Berman)
678f5da wallet: create set_subaddress_lookahead wallet rpc endpoint (benevanoff)
8f5a7b0 wallet: ensure subaddress keys table is at least size of requested lookahead (benevanoff)
2025-07-10 12:19:42 +00:00
tobtoht f1ffcc5c49 Merge pull request #9978
e0df82e simplewallet: respect `do-not-relay` in `sweep_single` (hinto.janai)
2025-07-10 12:18:34 +00:00
selsta b96af8e17a build: prepare v0.18.4.1 2025-07-09 16:12:16 +02:00
hinto.janai e0df82eb00 simplewallet: respect do-not-relay in sweep_single 2025-07-08 13:05:25 +00:00
tobtoht 75ae1f33b4 Merge pull request #9949
ac22479 Add is_same_host check to p2p (Lee *!* Clagett)
2025-07-08 09:29:36 +00:00
jeffro256andnahuhh 1da19dac54 wallet: refactor subaddress expansion & add to transfer test 2025-07-07 22:21:46 +00:00
Justin Bermanandnahuhh e23d51bc16 wallet: improve lookahead logic & make rpc persistent 2025-07-07 22:21:43 +00:00
benevanoffandnahuhh 678f5dab31 wallet: create set_subaddress_lookahead wallet rpc endpoint 2025-07-07 22:21:39 +00:00
tobtoht 3176fbd7fb Merge pull request #9956
9f3d96e Add check for exception in tcp accept handler (Lee *!* Clagett)
2025-07-07 19:38:55 +00:00
tobtoht 8c963a5601 Merge pull request #9966
02b29af cmake: don't redefine project (tobtoht)
2025-07-07 19:37:59 +00:00
benevanoffandnahuhh 8f5a7b0f1a wallet: ensure subaddress keys table is at least size of requested lookahead 2025-07-03 16:10:29 +00:00
tobtoht 02b29af682 cmake: don't redefine project 2025-06-24 07:12:59 +02:00
tobtoht 7acee8dba7 ci: bump debian to 11 [0.18] 2025-06-15 21:36:06 +02:00
tobtoht 43af228ce6 Merge pull request #9950
8375edf wallet:set refresh interval to default when hitting tip of chain (tzadiko)
22d2d53 wallet: fix monero-wallet-rpc ignoring calls during sync (tzadiko)
2025-06-14 19:01:37 +00:00
tobtoht b01fb18012 Merge pull request #9909
f968150 epee: fix string_tools on Windows (0xFFFC0000)
2025-06-14 18:59:23 +00:00
tobtoht 3c644537b7 Merge pull request #9945
273d368 fix issue 9943: cli using wrong filename for storing keys (Rudolf Schmidt)
2025-06-14 18:57:09 +00:00
Lee Clagett 9002681c1e Add new dynamic fees to ZMQ 2025-06-13 17:27:36 -04:00
Lee *!* Clagett 9f3d96eba6 Add check for exception in tcp accept handler 2025-06-12 17:48:49 -04:00