Commit Graph

7690 Commits

Author SHA1 Message Date
WeebDataHoarder
39c7a22856 Send ZMQ miner notifications after txpool additions
Bug was introduced in c069c04ede, before this txpool additions were not notified on block addition

When receiving blocks with previously unknown conditions, miner data was sent first, but txpool add events for already-added transactions in previous block were sent afterward. Miners would then include already-mined transactions in their new templates due to receiving the mistimed txpool add event.

The fix is to send miner notifications AFTER txpool events are sent, and before normal block notifications are sent (for mining switch speed purposes)

Fixes c069c04ede / #9135
Fixes dfee15eee1 / #7891
2025-09-24 09:22:28 +02:00
tobtoht
d87edf57fc Merge pull request #10051
f921431 checkpoints: update to a recent block height (selsta)
2025-08-21 16:29:21 +00:00
selsta
f921431f34 checkpoints: update to a recent block height 2025-08-20 18:42:13 +02:00
Lee *!* Clagett
e23b759b37 Skip ping connections in outgoing count 2025-08-19 17:16:05 -04:00
tobtoht
2987b72006 Merge pull request #10019
32f701b build: prepare v0.18.4.2 (selsta)
2025-08-05 16:09:20 +00:00
selsta
32f701b0cd build: prepare v0.18.4.2 2025-08-01 17:25:46 +02:00
jeffro256
8f98dac4f0 wallet: deprecate wallet2::find_and_save_rings()
Rings for outgoing transactions are stored within the scanning code since the last hardfork,
so this code is largely unneccessary now.

Co-authored-by: j-berman <justinberman@protonmail.com>
2025-07-29 12:32:20 -05:00
SNeedlewoods
2e0030cba8 set do_not_relay always false in submit_multisig_main 2025-07-14 18:41:25 +02:00
tobtoht
d95cd26330 Merge pull request #9982
45152f9 rpc: return error correctly on bad key image string (jeffro256)
2025-07-13 16:52:45 +00:00
tobtoht
191a41ed3a Merge pull request #9983
bec90df add do_not_relay option to submit_multisig_main command in simplewallet (SNeedlewoods)
2025-07-13 16:51:20 +00:00
jeffro256
1d3d30c507 crypto: check+throw for Cryptonight v1 invalid input
If `crypto::cn_slow_hash()` is called with `variant=1` and an input length of less thab 43 bytes, it triggers a program exit.
This checks first and throws an exception instead.

Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!
2025-07-11 11:37:08 -05:00
jeffro256
45152f9ef0 rpc: return error correctly on bad key image string
Because of the missing `return` statement, the status is set to "OK" later on in the method when it shouldn't be.

Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!
2025-07-11 11:27:12 -05:00
SNeedlewoods
bec90df7ec add do_not_relay option to submit_multisig_main command in simplewallet 2025-07-11 17:48:33 +02:00
tobtoht
3e218c2021 Merge pull request #9958
9002681 Add new dynamic fees to ZMQ (Lee Clagett)
2025-07-10 17:32:31 +00:00
tobtoht
0b739fdf58 Merge pull request #9946
b96af8e build: prepare v0.18.4.1 (selsta)
2025-07-10 12:28:33 +00:00
tobtoht
8b4f0a6258 Merge pull request #9954
1da19da wallet: refactor subaddress expansion & add to transfer test (jeffro256)
e23d51b wallet: improve lookahead logic & make rpc persistent (Justin Berman)
678f5da wallet: create set_subaddress_lookahead wallet rpc endpoint (benevanoff)
8f5a7b0 wallet: ensure subaddress keys table is at least size of requested lookahead (benevanoff)
2025-07-10 12:19:42 +00:00
tobtoht
f1ffcc5c49 Merge pull request #9978
e0df82e simplewallet: respect `do-not-relay` in `sweep_single` (hinto.janai)
2025-07-10 12:18:34 +00:00
selsta
b96af8e17a build: prepare v0.18.4.1 2025-07-09 16:12:16 +02:00
hinto.janai
e0df82eb00 simplewallet: respect do-not-relay in sweep_single 2025-07-08 13:05:25 +00:00
tobtoht
75ae1f33b4 Merge pull request #9949
ac22479 Add is_same_host check to p2p (Lee *!* Clagett)
2025-07-08 09:29:36 +00:00
jeffro256
1da19dac54 wallet: refactor subaddress expansion & add to transfer test 2025-07-07 22:21:46 +00:00
Justin Berman
e23d51bc16 wallet: improve lookahead logic & make rpc persistent 2025-07-07 22:21:43 +00:00
benevanoff
678f5dab31 wallet: create set_subaddress_lookahead wallet rpc endpoint 2025-07-07 22:21:39 +00:00
benevanoff
8f5a7b0f1a wallet: ensure subaddress keys table is at least size of requested lookahead 2025-07-03 16:10:29 +00:00
tobtoht
02b29af682 cmake: don't redefine project 2025-06-24 07:12:59 +02:00
tobtoht
43af228ce6 Merge pull request #9950
8375edf wallet:set refresh interval to default when hitting tip of chain (tzadiko)
22d2d53 wallet: fix monero-wallet-rpc ignoring calls during sync (tzadiko)
2025-06-14 19:01:37 +00:00
Lee Clagett
9002681c1e Add new dynamic fees to ZMQ 2025-06-13 17:27:36 -04:00
tzadiko
8375edfc30 wallet:set refresh interval to default when hitting tip of chain 2025-06-07 19:47:15 -05:00
tzadiko
22d2d53af0 wallet: fix monero-wallet-rpc ignoring calls during sync 2025-06-07 19:47:09 -05:00
Lee *!* Clagett
ac22479f91 Add is_same_host check to p2p 2025-06-07 18:23:27 -04:00
Rudolf Schmidt
273d368aac fix issue 9943: cli using wrong filename for storing keys 2025-06-07 15:47:16 +02:00
jeffro256
e458bc0fad msys2 build: include int headers 2025-05-06 14:18:02 -05:00
SNeedlewoods
5550c0a876 fix: multisig stale data after failed refresh 2025-04-24 12:42:39 +02:00
tobtoht
f1311d4237 Merge pull request #9864
97e1a49dd checkpoints: update to a recent block height (selsta)
2025-03-26 12:37:43 +00:00
tzadiko
ba2dadb0d4 Correct Max / Min Block Waiting Periods 2025-03-25 18:55:04 -05:00
selsta
97e1a49dd7 checkpoints: update to a recent block height 2025-03-25 21:22:47 +01:00
Lee *!* Clagett
c8f7735014 Fix expected hash check 2025-03-24 10:59:50 -04:00
tobtoht
4b7263d587 Merge pull request #9854
c7f01e57f Blockchain: remove skip for pruned txs in `check_tx_inputs()` (jeffro256)
2025-03-24 02:56:51 +00:00
tobtoht
f373684b41 Merge pull request #9853
ce1c864b4 cryptonote_protocol: fix handling of pruned blocks during sync (jeffro256)
2025-03-24 02:56:05 +00:00
tobtoht
f118605e67 Merge pull request #9836
9468a5e54 cryptonote_basic: remove unused struct (tobtoht)
2025-03-24 02:47:12 +00:00
jeffro256
c7f01e57f5 Blockchain: remove skip for pruned txs in check_tx_inputs()
I can't see how this would trigger in the current codebase, so it's not a *current* safety issue,
but I can very well see it becoming on in the future if downstream code doesn't handle the passing
of pruned transactions correctly. I think the safe/good choice would be to remove this skip now
that all transactions that pass into the mempool are supposed to be unpruned. And for all in-block
txs, `check_tx_inputs()` isn't called for checkpointed blocks, and we sync pruned blocks only if
syncing checkpointed blocks.
2025-03-19 23:25:48 -05:00
jeffro256
ce1c864b4d cryptonote_protocol: fix handling of pruned blocks during sync 2025-03-19 17:37:53 -05:00
tobtoht
bdcfd32f63 trezor: fix protobuf 30 compatibility 2025-03-18 08:36:13 +01:00
tobtoht
9468a5e544 cryptonote_basic: remove unused struct 2025-03-14 12:45:23 +01:00
tobtoht
3da68db978 Merge pull request #9740
008ba966d blockchain sync: reduce disk writes from 2 to 1 per tx (jeffro256)
2025-03-10 16:20:00 +00:00
jeffro256
008ba966da blockchain sync: reduce disk writes from 2 to 1 per tx 2025-03-10 01:32:08 -05:00
tobtoht
0232839913 Merge pull request #9805
33e33fbca BlockchainLMDB: fix data.mdb nuking on Windows (jeffro256)
2025-02-17 18:23:43 +00:00
jeffro256
33e33fbca3 BlockchainLMDB: fix data.mdb nuking on Windows 2025-02-17 12:13:37 -06:00
tobtoht
c476b87fcf Merge pull request #9803
6ccd3200b common: add missing iomanip include (tobtoht)
2025-02-17 16:34:55 +00:00
tobtoht
6ccd3200bf common: add missing iomanip include 2025-02-17 17:30:27 +01:00