Commit Graph

12262 Commits

Author SHA1 Message Date
tobtoht
687b7a4ac0 Merge pull request #10203
a378b59 tx pool: only increment m_txpool_weight for newly added pool txs (j-berman)
2025-11-12 09:19:59 +00:00
j-berman
a378b59628 tx pool: only increment m_txpool_weight for newly added pool txs
Otherwise we can end up double counting txs towards the weight,
which can over-state the pool weight. E.g. relay tx to node in
stem phase, add its weight to pool weight, then receive tx
from another node, then bump the pool weight again. That double
counts the tx towards the pool weight.

If the weight exceeds the max, the node will "prune" txs from the
pool. Thus, over-counting is probably a cause of, but perhaps
not the only cause of:
https://github.com/seraphis-migration/monero/issues/148
2025-11-11 16:31:01 -08:00
tobtoht
d6be783927 Merge pull request #10196
e89922a ledger: throw on secret view key export rejection (tobtoht)
2025-11-11 23:01:45 +00:00
tobtoht
cdaca019fc Merge pull request #10201
52b4c73 cryptonote_protocol: accurate next_needed_height when there is an overlap (0xFFFC0000)
2025-11-11 22:41:41 +00:00
tobtoht
6c17c7d1ad Merge pull request #10200
ef3fe66 src: update checkpoints to match v0.18.4.4 (selsta)
2025-11-11 21:53:12 +00:00
tobtoht
8d33b5c595 Merge pull request #10193
c01e1fa Fix logging deadlock (j-berman)
2025-11-11 21:51:02 +00:00
tobtoht
e89922a2fd ledger: throw on secret view key export rejection 2025-11-11 21:21:41 +01:00
j-berman
c01e1fa288 Fix logging deadlock 2025-11-11 10:43:39 -08:00
0xFFFC0000
52b4c73ab4 cryptonote_protocol: accurate next_needed_height when there is an overlap 2025-11-11 00:29:23 +03:30
selsta
ef3fe664fd src: update checkpoints to match v0.18.4.4 2025-11-10 19:00:50 +01:00
tobtoht
8a53c96b12 Merge pull request #10181
32d9359 fuzz: fix some warnings (jeffro256)
2025-11-06 19:04:23 +00:00
tobtoht
cdbf147c8b Merge pull request #10182
c3ee9ac release: drop support for arm32 linux (tobtoht)
2025-11-06 19:03:51 +00:00
tobtoht
fc812cdc14 Merge pull request #10005
0afe7d5 guix: bump time-machine to 3cd1c8769c618cab07181c6a4807792a371f0b2e (tobtoht)
2025-11-05 18:16:47 +00:00
tobtoht
0afe7d5e3e guix: bump time-machine to 3cd1c8769c618cab07181c6a4807792a371f0b2e 2025-11-01 20:25:33 +01:00
tobtoht
c3ee9ac707 release: drop support for arm32 linux 2025-11-01 12:06:22 +01:00
jeffro256
32d9359b9a fuzz: fix some warnings 2025-10-28 01:13:00 -05:00
tobtoht
6bb36309d6 Merge pull request #10123
4e9d199 daemon: fix print_cn command when 0 connections (jeffro256)
2025-10-27 18:52:36 +00:00
tobtoht
b4a168b5f8 Merge pull request #10083
daded36 wallet: identify spends in pool when scanning (j-berman)
2025-10-27 18:50:40 +00:00
tobtoht
fc6170a1f7 Merge pull request #10156
0fc5e87 cryptonote_core: rm confusing/redundant BP consensus rule (jeffro256)
2025-10-27 18:47:58 +00:00
tobtoht
0237f04617 Merge pull request #10172
5905b20 wallet: sanity check ring indices only against spendable (jeffro256)
2025-10-27 18:47:03 +00:00
jeffro256
5905b202f0 wallet: sanity check ring indices only against spendable 2025-10-15 17:00:21 -05:00
jeffro256
0fc5e87f2c cryptonote_core: rm confusing/redundant BP consensus rule
This rule is confusing/redundant because before v8, no
bulletproofs whatsoever were allowed. And during and after
v8, ONLY multi-output bulletproofs were allowed, i.e.
exactly 1 bulletproof is allowed which proves the range of
all amount commitments in the transaction.

Sources:
  * No BP before v8:
    - d32b5bfe18/src/cryptonote_core/blockchain.cpp (L3021-L3032)
  * Only 1 BP allowed:
    - d32b5bfe18/src/cryptonote_basic/cryptonote_format_utils.cpp (L174)
    - d32b5bfe18/src/cryptonote_basic/cryptonote_format_utils.cpp (L150)
  * BP must cover all outputs:
    - d32b5bfe18/src/cryptonote_basic/cryptonote_format_utils.cpp (L190-L194)
    - d32b5bfe18/src/cryptonote_basic/cryptonote_format_utils.cpp (L166-L170)
2025-10-09 15:57:54 -05:00
tobtoht
d32b5bfe18 Merge pull request #9672
335fb0b depends: openssl: update to 3.5.4 (tobtoht)
2025-10-08 18:28:14 +00:00
tobtoht
335fb0b28c depends: openssl: update to 3.5.4 2025-10-08 12:26:52 +02:00
luigi1111
0d500f5349 Merge pull request #9752
8d6855c CoC: only allow Administrators to merge changes to the CoC (tobtoht)
2025-10-07 15:46:02 -04:00
luigi1111
3e2faec4da Merge pull request #9750
e3db452 CoC: 'log an issue' -> 'open an issue' (tobtoht)
2025-10-07 15:45:29 -04:00
luigi1111
177e14ac56 Merge pull request #9749
5c32fbd CoC: do not encourage using real names or 'well-known aliases' (tobtoht)
2025-10-07 15:44:52 -04:00
luigi1111
d3b80ce528 Merge pull request #9478
b9bead5 CoC: prohibit anyone from committing patches to the project directly (tobtoht)
2025-10-07 15:44:07 -04:00
luigi1111
ebfb495512 Merge pull request #9744
dc5e15c CoC: remove constraint suggesting copyright can be 'owned collectively' (tobtoht)
2025-10-07 15:42:52 -04:00
luigi1111
9f1686ef78 Merge pull request #9743
53cb44c CoC: remove constraints on 'release history' (tobtoht)
2025-10-07 15:42:18 -04:00
luigi1111
574d50ffc2 Merge pull request #9742
a60c108 CoC: clarify 'project founders' (tobtoht)
2025-10-07 15:41:38 -04:00
luigi1111
46d794f98e Merge pull request #9737
70d3907 docs: remove 'creating stable releases' section (tobtoht)
2025-10-07 15:40:24 -04:00
luigi1111
3f4f292847 Merge pull request #9735
69020aa docs: remove 'Monero Maintainer Team' (tobtoht)
2025-10-07 15:39:37 -04:00
luigi1111
0089f38682 Merge pull request #9733
8154b90 docs: do not automatically promote contributors to maintainers (tobtoht)
2025-10-07 15:34:19 -04:00
luigi1111
8f3ae08521 Merge pull request #9732
9bd265d docs: don't allow maintainers to edit docs without review (tobtoht)
2025-10-07 15:32:40 -04:00
luigi1111
42ed3c70ef Merge pull request #9730
5345eba docs: allow maintainers to merge their own prs if queued (tobtoht)
2025-10-07 15:32:02 -04:00
luigi1111
a5aa602dce Merge pull request #10147
292c053 Cleaner validation (faster and saner) (j-berman)
2025-10-07 15:22:35 -04:00
luigi1111
8e98fa954c Merge pull request #10146
ca27d51 cryptonote_basic: remove redundant call to get_transaction_hash() in overload (jeffro256)
2025-10-07 15:21:02 -04:00
luigi1111
e0d83e0ebb Merge pull request #10109
be79b83 Daemon RPC: fix on_getblockhash error return on too high height (j-berman)
2025-10-07 15:18:26 -04:00
luigi1111
df90240542 Merge pull request #10107
0fb4a8f src: update checkpoints to match v0.18.4.3 (selsta)
2025-10-07 15:17:44 -04:00
luigi1111
44b242d56f Merge pull request #10086
1dbb4a7 wallet2: warn instead of throw when RingDB doesn't include spend (j-berman)
2025-10-07 15:15:23 -04:00
selsta
0fb4a8f9b1 src: update checkpoints to match v0.18.4.3 2025-10-07 16:37:18 +02:00
j-berman
292c053280 Cleaner validation (faster and saner) 2025-10-06 12:51:16 -07:00
jeffro256
ca27d519df cryptonote_basic: remove redundant call to get_transaction_hash() in overload
Issue noticed by DataHoarder.
2025-10-05 16:47:57 -05:00
jeffro256
4e9d199913 daemon: fix print_cn command when 0 connections
Deferencing the result of `std::max_element()` when `res.connections` has 0 elements leads to UB, and segfaults in practice.

Co-authored-by: iamamyth <user@example.com>
2025-09-28 13:55:44 -05:00
tobtoht
8e9ab9677f Merge pull request #10097
9308fd7 simplewallet: batch address creation limit to match rpc (nahuhh)
2025-09-28 18:34:44 +00:00
tobtoht
adc395577a Merge pull request #10103
bc8b210 Send ZMQ miner notifications after txpool additions (WeebDataHoarder)
2025-09-28 18:33:35 +00:00
tobtoht
a6d0ac3fdb Merge pull request #10110
5e5a52e removing lza_menace seed nodes (lza_menace)
2025-09-28 18:32:52 +00:00
tobtoht
5240ee5438 Merge pull request #9939
ae489ba p2p: Improved peer selection with /24 subnet deduplication to disadvantage 'spy nodes' (rbrunner7)
2025-09-28 18:30:41 +00:00
tobtoht
0cc56f6373 Merge pull request #10114
6c49352 net_node: add hinto seed nodes (hinto.janai)
2025-09-28 18:29:09 +00:00