tobtoht
e00908bc49
Merge pull request #10921
...
edea850 general: replace auto_scope_leave_caller with scope_guard (jeffro256)
ACKs: selsta, tobtoht
2026-07-22 16:31:31 +00:00
jeffro256
edea8505db
general: replace auto_scope_leave_caller with scope_guard
...
And replace unused inclusions of misc_language.h
2026-07-15 19:54:58 -05:00
selsta
0b7967907f
wallet2: guard gamma picker against zero-output windows
2026-07-14 19:41:36 +02:00
tobtoht
23372d12f5
Merge pull request #10108
...
ede4d7f RingCT crypto: 6x faster zero commit (j-berman)
ACKs: UkoeHB, jeffro256
2026-07-03 11:57:32 +00:00
tobtoht
381fce8dde
Merge pull request #10828
...
fecef76 Fix spelling typos in comments and string literals (Thomas)
ACKs: tobtoht, selsta
2026-07-02 13:18:56 +00:00
tobtoht
a2de04a09b
Merge pull request #10825
...
b1f4561 wallet2: remove unused pool tx removed callback (selsta)
ACKs: tobtoht, thomasbuilds
2026-07-01 17:40:04 +00:00
tobtoht
85d5a6f95b
Merge pull request #10646
...
d40944c wallet2: avoid linear scans in pool state updates (selsta)
ACKs: j-berman*, SChernykh
2026-06-28 14:20:30 +00:00
selsta
d40944c4df
wallet2: avoid linear scans in pool state updates
2026-06-28 13:54:10 +02:00
Thomas
fecef767c9
Fix spelling typos in comments and string literals
2026-06-27 09:53:48 +02:00
tobtoht
f79930b0db
Merge pull request #10796
...
36bb2d0 wallet2: avoid std::out_of_range on a truncated tx set blob (Thomas)
ACKs: jeffro256, selsta
2026-06-26 16:14:06 +00:00
selsta
b1f456140a
wallet2: remove unused pool tx removed callback
...
on_pool_tx_removed has no implementation beyond the empty default callback
and is not wired through the wallet API layer.
The only call site passed txid after erasing the payment entry that owned it,
leaving a dangling reference.
2026-06-26 02:53:41 +02:00
tobtoht
0a83a39883
Merge pull request #10792
...
02db831 Fix spelling typos (Thomas)
ACKs: tobtoht, jeffro256
2026-06-24 17:21:24 +00:00
tobtoht
e4a77fbb42
Merge pull request #10775
...
57f4cda wallet2: guard optimized coinbase refresh against empty vout (selsta)
ACKs: tobtoht, SChernykh
2026-06-21 11:39:04 +00:00
tobtoht
0651be79f9
Merge pull request #10772
...
7578af4 wallet2: reject non-monotonic rct output distributions (selsta)
ACKs: jeffro256, vtnerd
2026-06-21 11:38:15 +00:00
Thomas
36bb2d0e7d
wallet2: avoid std::out_of_range on a truncated tx set blob
...
parse_unsigned_tx_from_str() and parse_tx_from_str() strip the magic,
then read the version byte and call s.substr(1) without checking a
version byte follows. A blob equal to just the magic leaves an empty
remainder, so s.substr(1) throws std::out_of_range instead of the
function returning false. Require magic + a version byte first.
2026-06-20 21:13:30 +02:00
Thomas
02db831d01
Fix spelling typos
2026-06-18 09:30:42 +02:00
tobtoht
6476ec8f2c
Merge pull request #10700
...
6ad3dc0 wallet2: read multisig restore fields with memcpy in generate (alhudz)
ACKs: vtnerd, selsta
2026-06-17 18:30:00 +00:00
tobtoht
f0e7c5b1ae
Merge pull request #10753
...
74f0917 wallet2: store multisig nonce erasure before returning signed txset (selsta)
ACKs: UkoeHB, tobtoht
2026-06-16 11:06:23 +00:00
alhudz
6ad3dc08f7
wallet2: read multisig restore fields with memcpy in generate
2026-06-16 00:19:33 +05:30
selsta
7578af44fe
wallet2: reject non-monotonic rct output distributions
2026-06-15 13:41:54 +02:00
tobtoht
757679bb6a
Merge pull request #10744
...
f1ea616 fix signed unsigned comparison (SNeedlewoods)
ACKs: selsta, tobtoht
2026-06-14 15:59:40 +00:00
tobtoht
9bd2ee44cd
Merge pull request #10728
...
af10a4f read import blob crypto fields with memcpy in wallet2 (alhudz)
2026-06-11 20:26:05 +00:00
tobtoht
887f2486fe
Merge pull request #8758
...
3af06e5 wallet: remove output blackballing (tobtoht)
2026-06-11 20:20:38 +00:00
SNeedlewoods
f1ea6167b3
fix signed unsigned comparison
2026-06-10 21:03:56 +02:00
selsta
74f0917d66
wallet2: store multisig nonce erasure before returning signed txset
2026-06-09 21:41:46 +02:00
jeffro256
589dd0a973
ringct: merge decodeRct and decodeRctSimple
2026-06-05 12:37:00 -05:00
alhudz
af10a4f6d4
read import blob crypto fields with memcpy in wallet2
2026-06-05 20:59:14 +05:30
tobtoht
22f7743b1f
Merge pull request #10647
...
10b0118 add safety for future fork heights (SNeedlewoods)
2026-06-03 19:02:00 +00:00
tobtoht
ee7bff978a
Merge pull request #10632
...
b3cd06d wallet2: clear m_additional_tx_keys during bg sync (selsta)
2026-05-28 21:29:22 +00:00
SNeedlewoods
10b0118c6a
add safety for future fork heights
2026-05-27 20:23:02 +02:00
tobtoht
f4bbdee14f
Merge pull request #10084
...
b4c5449 wallet: add `wallet2_basic` library types (jeffro256)
2026-05-25 20:48:17 +00:00
selsta
57f4cda12a
wallet2: guard optimized coinbase refresh against empty vout
2026-05-22 18:29:43 +02:00
selsta
b3cd06df90
wallet2: clear m_additional_tx_keys during bg sync
2026-05-21 00:44:30 +02:00
koe
d737072188
wallet2: refactor multisig ignore sets logic into separate functions
2026-05-19 19:36:01 -05:00
tobtoht
521a9b4c82
Merge pull request #10577
...
9a18697 wallet: roll back unlocker count on decrypt failure (fuyua9)
2026-05-19 19:55:47 +00:00
Thomas
2c327aa325
fix spelling in comments and docs
2026-05-13 21:20:05 +02:00
tobtoht
3af06e53d3
wallet: remove output blackballing
2026-05-11 19:50:01 +02:00
tobtoht
4766d3eb8c
Merge pull request #10165
...
50c3c50 use latest hard fork block for get_approximate_blockchain_height & update approximate_rolled_back_blocks (SNeedlewoods)
2026-05-10 17:40:26 +00:00
fuyua9
9a18697518
wallet: roll back unlocker count on decrypt failure
2026-05-10 13:23:04 +00:00
SNeedlewoods
50c3c50ba3
use latest hard fork block for get_approximate_blockchain_height & update approximate_rolled_back_blocks
2026-05-10 11:06:44 +02:00
b4c54499cd
wallet: add wallet2_basic library types
...
The `wallet2_basic` library is a minimalistic library for loading / storing historic `wallet2` files. It has several design goals:
* Enable future migration away from monolithic `wallet2` codebase without losing funds
* Simplify FCMP++/Carrot integration
* Speed-up compile-time for current codebase, but especially the FCMP++/Carrot integration, which is split over several translation units
Co-authored-by: j-berman <justinberman@protonmail.com >
Co-authored-by: selsta <selsta@sent.at >
2026-05-08 12:18:33 -05:00
tobtoht
49ea802139
Merge pull request #9899
...
05ab316 epee: better scope leaver (jeffro256)
2026-05-06 19:34:39 +00:00
jeffro256
05ab316853
epee: better scope leaver
...
1. Doesn't allocate a `boost::shared_ptr`
2. Doesn't use a vtable
3. Doesn't use `std::function` wrapper
4. Doesn't necessarily copy functional object
5. Doesn't need a factory function for simple declaration (yay CTAD)
6. Isolated to its own header
7. Name doesn't suck as much
2026-05-06 11:59:00 -05:00
tobtoht
2d48a39658
Merge pull request #10483
...
0617f43 fix: warning: ignored-attributes (tobtoht)
2cf3e27 fix: warning: unused-result (tobtoht)
d8f27be fix: warning: unused-function (tobtoht)
ffbb0cc fix: warning: unused-const-variable (tobtoht)
57975ab fix: warning: deprecated-declarations (tobtoht)
3294b8e fix: warning: unused-variable (tobtoht)
20f6f5f fix: warning: unused-lambda-capture (tobtoht)
37e76ec fix: warning: inconsistent-missing-override (tobtoht)
2026-05-04 16:36:28 +00:00
tobtoht
fa286745d0
Merge pull request #10472
...
18b634a wallet2: reject duplicate outputs in reserve proofs (selsta)
2026-04-29 13:32:50 +00:00
tobtoht
ca5b4e74d9
Merge pull request #10470
...
5835a23 wallet2: use decodeRct for reserve proof amount validation (selsta)
2026-04-29 12:30:05 +00:00
selsta
18b634a591
wallet2: reject duplicate outputs in reserve proofs
2026-04-29 14:25:46 +02:00
tobtoht
3294b8e891
fix: warning: unused-variable
2026-04-29 10:21:39 +02:00
tobtoht
c7640ed37f
Merge pull request #10475
...
172b4e1 fix: warning: variable set but not used (tobtoht)
2026-04-29 08:07:45 +00:00
tobtoht
172b4e1883
fix: warning: variable set but not used
2026-04-28 16:24:41 +02:00