Commit Graph
100 Commits
Author SHA1 Message Date
selsta 85f8bbbccb tests: make libwallet_api_tests work under ctest, add tests 2026-07-17 20:55:23 +02:00
selsta e5d701d4a3 tx_pool: remove redundant hashCompare comparator 2026-07-15 21:53:27 +02:00
selsta 0b7967907f wallet2: guard gamma picker against zero-output windows 2026-07-14 19:41:36 +02:00
selsta 850e32b09c workflows: split up test step 2026-07-11 17:33:17 +02:00
selsta 0dcafa84cb cmake: use wrapped __cxa_throw on GNU/Linux 2026-07-11 02:57:09 +02:00
selsta fe7986ec64 trezor: suppress generated protobuf deprecation warnings 2026-07-11 02:49:40 +02:00
selsta 09e3d2aec5 tests: fix libFuzzer build instructions on Ubuntu 2026-07-10 21:17:04 +02:00
selsta c9a18b96cb blockchain: fix misleading request chain error logs 2026-07-10 16:26:06 +02:00
selsta b3aca5f53f tests: fix epee connection lifetime race
The lifetime test waited only for the client-side socket count to
reach zero before reconnecting. Because server-side inbound connections
are tracked separately, they may still be tearing down asynchronously,
causing the next connection attempt to fail with ECONNRESET on macOS.

Wait for both client and server connection accounting to drain before
the next reconnect. Also use the error_code connect overload so failures
are reported by gtest instead of escaping as uncaught Boost exceptions.
2026-07-08 21:10:40 +02:00
selstaandjeffro256 dc8bc028a6 cryptonote: scope 202612 PoW workaround
The block 202612 PoW workaround previously applied to any block at
height 202612. Restrict it to the object hashes of the known historical
mainnet, testnet, and stagenet block hashing blobs so new chains do not
inherit the fixed PoW hash, which would prevent sync or mining past that
height if their difficulty is higher.

Reported-by: DataHoarder
Co-authored-by: jeffro256 <jeffro256@tutanota.com>
2026-07-03 14:59:41 +02:00
selsta 80402158fd functional_tests: avoid sweep_single spent status race 2026-07-03 14:04:12 +02:00
selsta ed3283dec9 Revert "functional_tests: add debug logging to transfer"
This reverts commit 2bc67262c8.
2026-07-03 01:02:46 +02:00
selsta d4cf18d668 tests: fix local AFL fuzz target build 2026-07-01 19:53:51 +02:00
selsta be7a5ecc4e epee: allow shared Windows file reads
Opening a file with a zero sharing mode makes read-only access exclusive
on Windows. Allow read and write sharing so callers can inspect files
that are already open, such as active log files.
2026-06-30 19:35:28 +02:00
selsta eaf139a25a tests: fix Windows unit test failures
Preserve line endings for test fixtures so file hashes remain stable
across platforms.

Temporarily release the wallet keys lock while inspecting the keys file,
then reacquire it and verify the lock state. This lets the test read the
file on Windows, where the lock prevents a concurrent read open.

Avoid passing possibly negative char values to std::isprint(), which is
undefined behavior except for EOF.
2026-06-30 18:39:11 +02:00
selsta a568ba39fa tests: avoid ephemeral p2p ports in node_server tests
48080 and 58080 are within common ephemeral port ranges, which can
make node_server tests intermittently fail to bind after recently
closed TCP connections used the same local source port.

Use fixed unit-test ports outside those ranges and keep the tests on
127.0.0.1 instead of relying on 127.0.0.2 being configured.
2026-06-30 13:41:59 +02:00
selsta c914c27c46 src: update checkpoints to match v0.18.5.1 2026-06-29 18:28:41 +02:00
selsta 265e95a8b5 blockchain: improve incoming block scan table handling 2026-06-29 14:07:28 +02:00
selsta 4a627d44fa tests: check node_server race init and connect 2026-06-28 19:24:36 +02:00
selsta d40944c4df wallet2: avoid linear scans in pool state updates 2026-06-28 13:54:10 +02:00
selsta 8fb41e9009 README: reorganize and harden Docker monerod instructions 2026-06-26 19:40:02 +02:00
selsta 2a9628b735 functional_tests_rpc: recreate socket for each startup probe 2026-06-26 14:51:38 +02:00
selsta 2bc67262c8 functional_tests: add debug logging to transfer 2026-06-26 14:38:36 +02:00
selsta b1f456140a wallet2: remove unused pool tx removed callback
on_pool_tx_removed has no implementation beyond the empty default callback
and is not wired through the wallet API layer.

The only call site passed txid after erasing the payment entry that owned it,
leaving a dangling reference.
2026-06-26 02:53:41 +02:00
selstaandBraden Linick 551bba60f9 tests: update fuzzing documentation
Co-authored-by: Braden Linick <blinick@alumni.nmu.edu>
2026-06-26 00:27:34 +02:00
selsta d8f3b81f79 p2p: restore safe sync mode when target height drops 2026-06-24 21:58:51 +02:00
selsta 389f3660db http: share deterministic header field parser 2026-06-21 22:25:58 +02:00
selsta 7578af44fe wallet2: reject non-monotonic rct output distributions 2026-06-15 13:41:54 +02:00
selsta d72cd7fc16 net: cap aggregate ZMQ receive size 2026-06-10 19:49:23 +02:00
selsta 74f0917d66 wallet2: store multisig nonce erasure before returning signed txset 2026-06-09 21:41:46 +02:00
selsta f095abd9aa wallet_rpc_server: preserve payment ID when editing address book 2026-06-03 22:36:03 +02:00
selsta 0fc5bb7c86 net: canonicalize Tor/I2P hosts during deserialization 2026-06-03 17:20:11 +02:00
selsta f2afe976c7 p2p: close zone connections before stopping net servers 2026-06-03 12:16:02 +02:00
selsta 29b04575eb workflows: use matrix for linux 2026-06-01 22:17:49 +02:00
selsta 108857032f tests: avoid null argv in program options setup 2026-06-01 00:51:37 +02:00
selsta 9f6ffb5468 workflows: speed up slow-hash in PR core_tests 2026-05-31 23:26:46 +02:00
selsta 3623399ea2 p2p: make stop signal idempotent 2026-05-31 02:45:53 +02:00
selsta f8aeff5ad3 seraphis_crypto: remove unused transcript utility 2026-05-26 18:58:17 +02:00
selsta 438f7f9fc4 net: canonicalize Tor and I2P hostnames 2026-05-23 00:58:54 +02:00
selsta 57f4cda12a wallet2: guard optimized coinbase refresh against empty vout 2026-05-22 18:29:43 +02:00
selsta 1bed4e8f39 serialization: handle EOF at varint boundary 2026-05-22 00:38:50 +02:00
selsta b3cd06df90 wallet2: clear m_additional_tx_keys during bg sync 2026-05-21 00:44:30 +02:00
selsta f1ae8ca4ee wallet_rpc_server: add missing background check
Reported by ro1m
2026-05-20 19:10:36 +02:00
selsta 7cc6b0fbad wallet_rpc_server: remove unused finalize_multisig endpoint 2026-05-19 20:54:47 +02:00
selsta b393830309 utils: add missing rpc flags to fish autocomplete 2026-05-19 19:20:44 +02:00
selsta 841ef74376 workflows: fix ccache dir path 2026-05-18 15:33:33 +02:00
selsta 758aa14f06 rpc: restrict get_alt_blocks_hashes 2026-05-15 23:01:58 +02:00
selsta 4b58b63083 tests: avoid braced scalar init in expect macros 2026-05-15 21:40:01 +02:00
selsta a307fcbf19 cmake: enable linker-aware library de-duplication 2026-05-15 17:22:11 +02:00
selsta d763d4346e daemonizer: avoid unsafe pidfile truncation 2026-05-15 16:05:37 +02:00
selsta 6fc7aa8398 cryptonote_protocol: fix peer overview logging 2026-05-14 18:09:48 +02:00
selsta f4795a0001 Remove obsolete test-drop-download debug options
These options were introduced in 2015 as manual debug helpers for
network-limit testing. They are not used by the current test suite.
2026-05-14 17:56:54 +02:00
selsta 06d7bdd059 lmdb: mark Apple text_env section as code 2026-05-13 17:24:24 +02:00
selsta f3128c6e5a rpc: reject invalid JSON-RPC ids in ZMQ requests 2026-05-11 12:03:54 +02:00
selsta 642e6369d5 epee: avoid memcpy in rolling median move 2026-05-11 02:57:36 +02:00
selsta 4bec447496 tests: remove obsolete memwipe optimization override 2026-05-09 23:56:26 +02:00
selsta 6460917cab serialization: avoid blob memcpy of secret_key vector 2026-05-09 23:42:51 +02:00
selsta 2e8a391d57 src: replace deprecated sprintf calls 2026-05-09 20:44:15 +02:00
selsta fe9b5de85f rpc: remove unused origin flag 2026-05-09 20:33:36 +02:00
selsta dae0f4cf61 wallet_rpc_server: add missing trusted daemon check 2026-05-07 22:55:39 +02:00
selsta f991cf23d9 zmq: switch to RapidJSON iterative parsing 2026-05-07 19:53:00 +02:00
selsta fe3e23a5a2 daemon: clarify limitations of restricted ZMQ RPC in help text 2026-04-29 19:02:02 +02:00
selsta 5d1feb5996 zmq: add restricted checks to GetInfo 2026-04-29 18:54:14 +02:00
selsta 18b634a591 wallet2: reject duplicate outputs in reserve proofs 2026-04-29 14:25:46 +02:00
selsta 2009084cc4 cryptonote_core: restore separate fakechain data dir for core_tests 2026-04-29 02:02:13 +02:00
selsta 13b42258b2 p2p: check p2p state before parsing in handle_notify_new_transactions 2026-04-28 18:21:51 +02:00
selsta b7fbe95eeb wallet2: ensure daemon returns correct tx for spend proof 2026-04-28 15:27:11 +02:00
selsta ccba74ce5e src: update checkpoints to match v0.18.5.0 2026-04-28 03:41:51 +02:00
selsta 5835a2378e wallet2: use decodeRct for reserve proof amount validation
also update check_tx_key_helper for consistency
2026-04-27 22:13:36 +02:00
selsta dca8e339bc rpc: remove last usage of txs_as_hex 2026-04-24 23:55:58 +02:00
selsta fa740d7af8 wallet2: remove deprecated txs_as_hex
also add missing underflow check
2026-04-24 23:36:06 +02:00
selsta 45995964e1 zmq: add more missing restricted rpc checks 2026-04-24 17:34:25 +02:00
selsta 9731bbfbf5 wallet_rpc_server: restrict relay_tx 2026-04-21 19:42:36 +02:00
selsta 3d2eb0ea8a wallet_rpc_server: fix ssl_allowed_fingerprints hex parsing 2026-04-21 13:35:58 +02:00
selsta bb449fd745 wallet2: add parse multisig tx sanity checks 2026-04-20 00:24:12 +02:00
selsta 43d84ce92c zmq: add missing restricted rpc check 2026-04-18 17:36:21 +02:00
selsta b6bd8291c9 db_lmdb: remove unused txpool_blob cursor 2026-04-13 18:57:28 +02:00
selsta b19cd82177 wallet2: fix background wallet detection in verify_password() 2026-04-06 19:33:03 +02:00
selsta 1498737f7f zmq: add restricted rpc mode 2026-04-01 18:04:24 +02:00
selsta 1c97b0d0f2 abstract_tcp_server2: add missing return 2026-03-26 22:58:32 +01:00
selsta 62a3214d34 windows_service: quote service executable path 2026-02-24 16:08:45 +01:00
selsta f459bd655e src: update checkpoints to match v0.18.4.6 2026-02-13 18:23:07 +01:00
selsta 80043b928b p2p: fix inverted ternary in peer list filter 2026-02-13 18:09:02 +01:00
selsta 1a59ede7fc docs: reduce 3 to 2 approvals for maintainer merging 2026-02-03 19:28:30 +01:00
selsta 590558960f src: update checkpoints to match v0.18.4.5 2025-12-29 22:29:17 +01:00
selsta ef3fe664fd src: update checkpoints to match v0.18.4.4 2025-11-10 19:00:50 +01:00
selsta 0fb4a8f9b1 src: update checkpoints to match v0.18.4.3 2025-10-07 16:37:18 +02:00
selsta b74ca72bad cmake: set minimum to 3.10 to fix warnings 2025-09-08 20:12:45 +02:00
selsta ca484323c3 epee: only parse valid port
Reported by hacksandhops and Ada Logic.
2025-08-29 11:45:02 +02:00
selsta cc444a937d checkpoints: update to a recent block height 2025-08-20 18:40:18 +02:00
selsta c08f1114de src: update checkpoints to match v0.18.4.2 2025-08-01 17:27:51 +02:00
selsta 00237fe18a src: update checkpoints to match v0.18.4.1 2025-07-10 15:31:54 +02:00
selsta 0e243a4ac0 checkpoints: update to a recent block height 2025-03-25 21:28:20 +01:00
selsta 26b4f5e00c Revert "blockchain: detect and log bad difficulty calculations"
This reverts commit 5741b4d74d.
2025-01-14 13:04:25 +01:00
selsta f3349b9dd6 daemon: fix log message typo 2025-01-14 11:17:43 +01:00
selsta 797811d84b dns_util: add new DNSSEC trust anchor 2024-12-01 16:01:41 +01:00
selsta 3216165822 src: update checkpoints to match v0.18.3.4 (again) 2024-07-31 18:14:23 +02:00
selsta 98172930db workflows: don't hardcode repo name 2024-06-03 03:27:35 +02:00
selsta 0fad1a8d08 src: update checkpoints to match v0.18.3.4 2024-05-29 15:59:56 +02:00
selsta a28c38c946 wallet2: correct variable usage in get_multisig_seed 2024-05-21 19:22:39 +02:00