Doyle 15538f7e3f ByteSlice: Fix persisting ptr to std::moved SSO buffer ...

The Bug:
1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_`
2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer)
3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.

2020-05-20 10:13:58 +10:00

58 KiB

Raw Blame History

View Raw