gitea-mirror/capa
1
0
Fork 0
mirror of https://github.com/mandiant/capa.git synced 2026-06-12 19:11:32 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove dead view_tab_rulegen assignment from CapaExplorerForm

Browse Source 
self.view_tab_rulegen = None was assigned but never read or reassigned anywhere in the codebase. All other attributes in the same block are type-annotated declarations; this one was an actual assignment with no purpose.
This commit is contained in:
Willi Ballenthin
2026-04-22 20:24:06 +03:00
committed by Willi Ballenthin
parent ce8cecc059
commit 7406e75f96
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+1 -2
View File
@@ -48,8 +48,7 @@
- fix: remove unreachable backports.functools_lru_cache fallback and dead dependency @williballenthin
- fix: Scopes.from_dict uses cls instead of self so subclasses return the correct type @williballenthin
- fix: correct wrong dict key in VMRay _compute_monitor_threads assertion (used thread_id instead of process_id) @williballenthin
fix: replace assert with isinstance guard in get_callee for invalid MethodSpec tokens @williballenthin
- fix: replace assert with isinstance guard in get_callee for invalid MethodSpec tokens @williballenthin
- fix: remove dead view_tab_rulegen assignment from CapaExplorerForm that was never read @williballenthin (SURF-70)
- fix: remove dead reset_query method from CapaExplorerSearchProxyModel that was never called @williballenthin (SURF-69)
- fix: remove unused imports of capa.rules and capa.engine from view.py @williballenthin (SURF-68)
- fix: remove unused imports of capa.main, capa.render.json, and capa.features.extractors.ida.extractor from form.py @williballenthin (SURF-67)
capa/ida/plugin/form.py
-1
View File
@@ -204,7 +204,6 @@ class CapaExplorerForm(idaapi.PluginForm):
self.view_search_bar: QtWidgets.QLineEdit
self.view_tree: CapaExplorerQtreeView
self.view_tabs: QtWidgets.QTabWidget
self.view_tab_rulegen = None
self.view_status_label: QtWidgets.QLabel
self.view_status_label_analysis_cache: str = ""
self.view_status_label_rulegen_cache: str = ""